Update to numba>=0.57. #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raydouglass
approved these changes
May 26, 2023
Merged
copy-pr-bot bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
numba-cuda is the NVIDIA-maintained CUDA target for Numba, which depends on the numba package. This PR replaces the numba dependency with numba-cuda. However, similar to @bdice's comment in #648, I don't know if we strictly need this here any more due to the cudf dependency (from rapidsai/cudf#16474) ensuring numba-cuda is present.
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
**EDIT:** This now removes the numba dependency, which comes transitively from cuDF. **Original description:** numba-cuda is the NVIDIA-maintained CUDA target for Numba, which depends on the numba package. This PR replaces the numba dependency with numba-cuda. However, similar to @bdice's comment in #648, I don't know if we strictly need this here any more due to the cudf dependency (from rapidsai/cudf#16474) ensuring numba-cuda is present. Authors: - Graham Markall (https://github.com/gmarkall) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) URL: #715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuDF now requires numba>=0.57.
I am not sure if this change is strictly needed or if cuDF's requirements will automatically enforce the greater lower bound.